Added documentation for tests:check-direct-dependency-use command, #PG-3272#778
Open
AltamashShaikh wants to merge 4 commits intolivefrom
Open
Added documentation for tests:check-direct-dependency-use command, #PG-3272#778AltamashShaikh wants to merge 4 commits intolivefrom
AltamashShaikh wants to merge 4 commits intolivefrom
Conversation
11 tasks
Contributor
|
Nice start, thanks @AltamashShaikh! Can we add a note why this might be useful to do? Why would plugin developers want to do this and if they find using core dependencies, what they can do about it? |
Contributor
Author
|
@michalkleiner Can you check now ? |
Contributor
|
Generally looking ok, just some minor tweaks/suggestions. |
Contributor
Author
|
@michalkleiner Applied all the feedback. |
Contributor
|
Thanks, I guess we shall wait for 5.1.0-beta1 release and then we can merge this documentation PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added documentation for tests:check-direct-dependency-use command
Fixes: #PG-3272
Review